Discussion:
[meta-freescale] [PATCH] DEPENDS_append is being used without a leading space, causing the concatenation of dependencies. Use += operator instead.
Hector
2018-10-17 18:29:59 UTC
Permalink
From: hector <***@gmail.com>

Signed-off-by: Hector Almeida <***@gmail.com>
---
recipes-bsp/u-boot/u-boot-imx_2017.03.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/recipes-bsp/u-boot/u-boot-imx_2017.03.bb b/recipes-bsp/u-boot/u-boot-imx_2017.03.bb
index 7220567..4aedf9c 100644
--- a/recipes-bsp/u-boot/u-boot-imx_2017.03.bb
+++ b/recipes-bsp/u-boot/u-boot-imx_2017.03.bb
@@ -6,7 +6,7 @@ DESCRIPTION = "i.MX U-Boot suppporting i.MX reference boards."
require recipes-bsp/u-boot/u-boot.inc

PROVIDES += "u-boot"
-DEPENDS_append = "dtc-native"
+DEPENDS += "dtc-native"

LICENSE = "GPLv2+"
LIC_FILES_CHKSUM = "file://Licenses/gpl-2.0.txt;md5=b234ee4d69f5fce4486a80fdaf4a4263"
--
2.7.4

--
Hector Almeida
2018-10-17 19:55:46 UTC
Permalink
Hi,

The patch I send could be applied to sumo and rocko branches. I saw that in
master branch, the u-boot-imx_2017.03.bb recipe has been updated and now
the DEPENDS_append is being set with the leading space in dtc-145.bbclass.

Regards,
Hector
Post by Hector
---
recipes-bsp/u-boot/u-boot-imx_2017.03.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/recipes-bsp/u-boot/u-boot-imx_2017.03.bb
b/recipes-bsp/u-boot/u-boot-imx_2017.03.bb
index 7220567..4aedf9c 100644
--- a/recipes-bsp/u-boot/u-boot-imx_2017.03.bb
+++ b/recipes-bsp/u-boot/u-boot-imx_2017.03.bb
@@ -6,7 +6,7 @@ DESCRIPTION = "i.MX U-Boot suppporting i.MX reference
boards."
require recipes-bsp/u-boot/u-boot.inc
PROVIDES += "u-boot"
-DEPENDS_append = "dtc-native"
+DEPENDS += "dtc-native"
LICENSE = "GPLv2+"
LIC_FILES_CHKSUM =
"file://Licenses/gpl-2.0.txt;md5=b234ee4d69f5fce4486a80fdaf4a4263"
--
2.7.4
Otavio Salvador
2018-10-27 18:16:05 UTC
Permalink
The patch I send could be applied to sumo and rocko branches. I saw that in master branch, the u-boot-imx_2017.03.bb recipe has been updated and now the DEPENDS_append is being set with the leading space in dtc-145.bbclass.
Please use:

DEPENDS_append = "<space>..."

as this is the smaller possible fix to address the issue. Also, please
fix the commit log to use:

u-boot-imx: <short description>
<empty line>
<long description>
<empty line>
Signed-off-by: ...

Reference: https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854 Mobile: +1 (347) 903-9750
--
Loading...